Change in vdsm[master]: Bug-Id: https://bugzilla.redhat.com/851839

asegurap at redhat.com asegurap at redhat.com
Mon Sep 3 09:21:48 UTC 2012


Antoni Segura Puimedon has posted comments on this change.

Change subject: Bug-Id: https://bugzilla.redhat.com/851839
......................................................................


Patch Set 2: (3 inline comments)

....................................................
Commit Message
Line 3: AuthorDate: 2012-09-02 03:26:37 +0200
Line 4: Commit:     Antoni S. Puimedon <asegurap at redhat.com>
Line 5: CommitDate: 2012-09-02 03:43:35 +0200
Line 6: 
Line 7: Bug-Id: https://bugzilla.redhat.com/851839
Done
Line 8: 
Line 9: This patch expands the logging done in network and traffic control by means of
Line 10: using vdsm.storage.misc.execCmd with a tailored logged that indicates which
Line 11: module is the origin of the logging.


Line 6: 
Line 7: Bug-Id: https://bugzilla.redhat.com/851839
Line 8: 
Line 9: This patch expands the logging done in network and traffic control by means of
Line 10: using vdsm.storage.misc.execCmd with a tailored logged that indicates which
I'm in the process of doing that.
I did study it and sent Saggi an email with some doubts I had about it. I'll do it asap.
Line 11: module is the origin of the logging.
Line 12: 
Line 13: It also substitutes some of the already existant logging uses with the module-
Line 14: specific logger created for the execCmd use.


....................................................
File vdsm/utils.py
Line 599: 
Line 600: def makeExecCmd(log=None):
Line 601:     from storage.misc import execCmd
Line 602:     if log is None:
Line 603:        return execCmd
Done
Line 604:     else:
Line 605:         def _execCmd(*args, **kwargs):
Line 606:             originalLogger = execCmd.func_globals['execCmdLogger']
Line 607:             execCmd.func_globals['execCmdLogger'] = log


--
To view, visit http://gerrit.ovirt.org/7662
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I825431e4a2cbb603fea2b5472b072e5d6a3862e9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Meni Yakove <myakove at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list