Change in vdsm[master]: configNetwork: _updateConfigValue: Add a new line char '\n' ...

danken at redhat.com danken at redhat.com
Mon Sep 3 07:05:06 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: configNetwork: _updateConfigValue: Add a new line char '\n' at the end of the line
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/configNetwork.py
Line 556:         with open(conffile) as f:
Line 557:             entries = [ line for line in f.readlines()
Line 558:                         if not line.startswith(entry + '=') ]
Line 559: 
Line 560:         if not delete:
we have to handle cfg files that existed before installation. I have a vague memory that we once had a customer bug about it. let's handle this corner case.
Line 561:             entries.append(entry + '=' + value + '\n')
Line 562: 
Line 563:         self._backup(conffile)
Line 564:         with open(conffile, 'w') as f:


--
To view, visit http://gerrit.ovirt.org/7688
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6030f0c92a2f3f2572b52cc48df6198da5cd2847
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list