Change in vdsm[master]: using blockStatsFlags to collect disk latency instead of qem...

danken at redhat.com danken at redhat.com
Mon Sep 3 06:42:22 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: using blockStatsFlags to collect disk latency instead of qemu cmd
......................................................................


Patch Set 7: I would prefer that you didn't submit this

(1 inline comment)

Thanks Royce, but now that this flag is defined in libvirt, let us use it.

....................................................
File vdsm/libvirtvm.py
Line 40: _VMCHANNEL_DEVICE_NAME = 'com.redhat.rhevm.vdsm'
Line 41: # This device name is used as default both in the qemu-guest-agent
Line 42: # service/daemon and in libvirtd (to be used with the quiesce flag).
Line 43: _QEMU_GA_DEVICE_NAME = 'org.qemu.guest_agent.0'
Line 44: _TYPED_PARAM_STRING_OKAY = 4
why not use libvirt.VIR_TYPED_PARAM_STRING_OKAY instead?
Line 45: 
Line 46: 
Line 47: class MERGESTATUS:
Line 48:     NOT_STARTED = "Not Started"


--
To view, visit http://gerrit.ovirt.org/4304
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id898b1456d874b1a02f04115e285e329eb1c81e0
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Xu He Jie <xuhj at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list