Change in vdsm[master]: Added glusterVolumeStatus verb

barumuga at redhat.com barumuga at redhat.com
Mon Sep 3 05:09:45 UTC 2012


Bala.FA has posted comments on this change.

Change subject: Added glusterVolumeStatus verb
......................................................................


Patch Set 7: (5 inline comments)

....................................................
File tests/gluster_cli_tests.py
Line 31: import xml.etree.cElementTree as etree
Line 32: 
Line 33: 
Line 34: class GlusterCliTests(TestCaseBase):
Line 35:     maxDiff = None
Its used by unittest to show full value on assertion.  A comment about maxDiff is good idea?!
Line 36: 
Line 37:     def setUp(self):
Line 38:         if not "gcli" in globals().keys():
Line 39:             raise SkipTest("vdsm-gluster not found")


Line 670:     </node>
Line 671:   </volStatus>
Line 672: </cliOutput>
Line 673: """
Line 674:         VolNameMarkerLocalStr = 'music-marker:marker_local_t'
This will go away if the expected value is assigned a local variable.
Line 675:         VolRpcsvcRequestStr = 'music-server:rpcsvc_request_t'
Line 676:         GlfsSavedFrameStr = 'glusterfs:struct saved_frame'
Line 677:         GlfsRpcReqStr = 'glusterfs:struct rpc_req'
Line 678:         GRpcsvcRequestStr = 'glusterfs:rpcsvc_request_t'


Line 678:         GRpcsvcRequestStr = 'glusterfs:rpcsvc_request_t'
Line 679:         tree = etree.fromstring(out)
Line 680:         status = gcli._parseVolumeStatusMem(tree)
Line 681:         self.assertEquals(status,
Line 682:                           {'bricks': \
Done
Line 683:                                [{'brick': '192.168.122.2:/tmp/music-b1',
Line 684:                                  'mallinfo': {'arena': '606208',
Line 685:                                               'fordblks': '132000',
Line 686:                                               'fsmblks': '64',


Line 679:         tree = etree.fromstring(out)
Line 680:         status = gcli._parseVolumeStatusMem(tree)
Line 681:         self.assertEquals(status,
Line 682:                           {'bricks': \
Line 683:                                [{'brick': '192.168.122.2:/tmp/music-b1',
Done
Line 684:                                  'mallinfo': {'arena': '606208',
Line 685:                                               'fordblks': '132000',
Line 686:                                               'fsmblks': '64',
Line 687:                                               'hblkhd': '15179776',


....................................................
File vdsm/gluster/api.py
Line 203:         self.svdsmProxy.glusterVolumeRemoveBrickForce(volumeName, brickList,
Line 204:                                                       replicaCount)
Line 205: 
Line 206:     @exportAsVerb
Line 207:     def volumeStatus(self, volumeName, statusOption=None, options=None):
If options are meant for custom compatibility changes, I am not sure how that will be achieved if we use options for statusOptions?!
Line 208:         status = self.svdsmProxy.glusterVolumeStatus(volumeName, statusOption)
Line 209:         return {'volumeStatus': status}
Line 210: 
Line 211:     @exportAsVerb


--
To view, visit http://gerrit.ovirt.org/6374
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8769c2da299a598ed7500c4780a3329972f4a8ac
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Vijay Bellur <vbellur at gmail.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list