Change in vdsm[master]: add simple VM creation functional test

zhshzhou at linux.vnet.ibm.com zhshzhou at linux.vnet.ibm.com
Mon Sep 3 02:55:53 UTC 2012


Zhou Zheng Sheng has posted comments on this change.

Change subject: add simple VM creation functional test
......................................................................


Patch Set 7: (3 inline comments)

Creating a initramfs on my machine costs 50s. Using the default arguments, initramfs generated by mkinitrd is 30M big. If we think 50s is too slow, we can cache the result.

....................................................
File configure.ac
Line 147: AC_PATH_PROG([LSBLK_PATH], [lsblk], [/bin/lsblk])
Line 148: AC_PATH_PROG([LVM_PATH], [lvm], [/sbin/lvm])
Line 149: AC_PATH_PROG([MKFS_PATH], [mkfs], [/sbin/mkfs])
Line 150: AC_PATH_PROG([MKFS_MSDOS_PATH], [mkfs.msdos], [/sbin/mkfs.msdos])
Line 151: AC_PATH_PROG([MKINITRD_PATH], [mkinitrd], [/usr/bin/mkinitrd])
Done
Line 152: AC_PATH_PROG([MKISOFS_PATH], [mkisofs], [/usr/bin/mkisofs])
Line 153: AC_PATH_PROG([MOUNT_PATH], [mount], [/bin/mount])
Line 154: AC_PATH_PROG([MULTIPATH_PATH], [multipath], [/sbin/multipath])
Line 155: AC_PATH_PROG([MV_PATH], [mv], [/bin/mv])


....................................................
File tests/functional/xmlrpcTests.py
Line 24: 
Line 25: from testrunner import VdsmTestCase as TestCaseBase
Line 26: from nose.plugins.skip import SkipTest
Line 27: from contextlib import contextmanager
Line 28: from storage.misc import execCmd
Done
Line 29: 
Line 30: from vdsm.config import config
Line 31: from vdsm import vdscli
Line 32: from vdsm.constants import EXT_MKINITRD


Line 61: 
Line 62: 
Line 63: def genInitramfs(kernelVer):
Line 64:     fd, path = tempfile.mkstemp()
Line 65:     cmd = [EXT_MKINITRD, "-f", path, kernelVer]
My machine: ThinkPad T420, Intel(R) Core(TM) i5-2540M CPU @ 2.60GHz, 4 logical cores.

"time mkinitrd -f initramfs.img 3.5.2-3.fc17.x86_64" gives the following output
 real	0m49.520s
 user	0m32.964s
 sys	0m16.170s
Line 66:     rc, out, err = execCmd(cmd, sudo=False)
Line 67:     os.chmod(path, 0644)
Line 68:     return path
Line 69: 


--
To view, visit http://gerrit.ovirt.org/7396
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb0d86ce20a547ef809d5407fe12d6ade474c4d2
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Deepak C Shetty <deepakcs at linux.vnet.ibm.com>
Gerrit-Reviewer: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list