Change in vdsm[master]: Move load_needed_modules to vdsm-tool

danken at redhat.com danken at redhat.com
Sun Sep 2 05:54:40 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Move load_needed_modules to vdsm-tool
......................................................................


Patch Set 5: (1 inline comment)

....................................................
File vdsm-tool/load_needed_modules.py.in
Line 44:                              stderr=subprocess.PIPE)
Line 45:         out, err = p.communicate()
Line 46:         rc = p.returncode
Line 47:     except:
Line 48:         logging.error(traceback.format_exc())
ok. then just check rc, raise an eception if non-zero, and move along.
Line 49: 
Line 50:     return (rc, out, err)
Line 51: 
Line 52: 


--
To view, visit http://gerrit.ovirt.org/7487
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icdc8f9d07a7150c4a846228811d6c5dcb17fa358
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenyi Gao <wenyi at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Wenyi Gao <wenyi at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list