Change in vdsm[master]: Offset by one for UUID position

danken at redhat.com danken at redhat.com
Sat Sep 1 19:11:30 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Offset by one for UUID position
......................................................................


Patch Set 2: I would prefer that you didn't submit this

Shu Ming, I was probably not clear in my previous comment: find that metaList[-3] would be a more robust way to get to spUUID - without worrying whether the configurable ends with a slash or not.

Could you also explain how you have verified your fix?

--
To view, visit http://gerrit.ovirt.org/7078
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9931a1aa804d9dc7aec1485ebc29bac45131d0e7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list