Change in vdsm[master]: Adding threads limitation to misc.tmap
ybronhei at redhat.com
ybronhei at redhat.com
Wed Oct 31 15:33:58 UTC 2012
Yaniv Bronhaim has posted comments on this change.
Change subject: Adding threads limitation to misc.tmap
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File tests/miscTests.py
Line 184: def testLimit(self):
Line 185: def dummy(arg):
Line 186: return arg
Line 187: data = frozenset([1, 2, 3, 4, 5])
Line 188: ret = frozenset(misc.tmap(dummy, data, 2))
The use of a frozenset instead of set means that the set values won't be changed during the code .. maybe you meant why do i need set at for.. i supposed to use a list or a tuple to verify that the values returned with the same order
Line 189: self.assertEquals(data, ret)
Line 190:
Line 191: def testErrMethod(self):
Line 192: exceptionStr = ("It's time to kick ass and chew bubble gum... " +
--
To view, visit http://gerrit.ovirt.org/8858
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I07845bfd78b9215e8994ac2ebe46a7ff78c85625
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
More information about the vdsm-patches
mailing list