Change in vdsm[master]: packaging: move /rhev/data-center to /var/lib/vdsm/data-cent...

ewoud at kohlvanwijngaarden.nl ewoud at kohlvanwijngaarden.nl
Wed Oct 31 15:07:53 UTC 2012


Ewoud Kohl van Wijngaarden has posted comments on this change.

Change subject: packaging: move /rhev/data-center to /var/lib/vdsm/data-center
......................................................................


Patch Set 6: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File tests/getAllVolumesTests.py
Line 61: 
Line 62:             Input file name: 'glob_<sdName>.out
Line 63:             Input file format: str(glob.glob(<imgsDir>))
Line 64:             When
Line 65:             <imgsDir> = @vdsmlibdir@/data-center/mnt/<mntPoint>/
It has been noted in previous patches that it's just a comment and the developer should do manual replacements in h(is|er) head. I agree that's a good enough solution.
Line 66:                             <sdName>/images/*.meta
Line 67:             """
Line 68:             sdPath, globExp = volMetaPattern.split('/images')
Line 69:             sdHead, sdName = os.path.split(sdPath)


....................................................
File vdsm.spec.in
Line 463: %post
Line 464: # upgrade old locations
Line 465: if [ -d /rhev/data-center -a -z "$(ls %{vdsmrepodir}/hsm-tasks)" ]; then
Line 466:     mv /rhev/data-center %{vdsmrepodir}/data-center.new && \
Line 467:         rm -rf %{vdsmrepodir} &&
Good catch.
Line 468:         mv %{vdsmrepodir}.new %{vdsmrepodir} &&
Line 469:         ( rmdir /rhev || : )
Line 470: fi
Line 471: 


--
To view, visit http://gerrit.ovirt.org/8500
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4ed316fedbf2e4d7e5bf741b7c77a39704994ae7
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud at kohlvanwijngaarden.nl>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ryan Harper <ryanh at us.ibm.com>


More information about the vdsm-patches mailing list