Change in vdsm[master]: Implement a zombie reaper

zhshzhou at linux.vnet.ibm.com zhshzhou at linux.vnet.ibm.com
Wed Oct 31 09:19:06 UTC 2012


Zhou Zheng Sheng has posted comments on this change.

Change subject: Implement a zombie reaper
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/zombieReaper.py
Line 15:             pid, rv = os.waitpid(pid, os.WNOHANG)
Line 16:             if pid != 0:
Line 17:                 _trackedPids.discard(pid)
Line 18:         except OSError:
Line 19:             _trackedPids.discard(pid)
If there is a signal sent to us, os.waitpid() will raise OSError with errno 4(Interrupted system call). In this case we should not discard pid, and we could retry os.waitpid().
Line 20: 
Line 21: 
Line 22: def _zombieReaper(signum, frame):
Line 23:     for pid in _trackedPids.copy():


--
To view, visit http://gerrit.ovirt.org/8937
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0fdf96e195135284b2733b21f611918ffbf69791
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Peter Portante <peter.portante at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list