Change in vdsm[master]: BZ#836161 - Rewrite of deleteImage().

shuming at linux.vnet.ibm.com shuming at linux.vnet.ibm.com
Wed Oct 31 09:09:23 UTC 2012


Shu Ming has posted comments on this change.

Change subject: BZ#836161 - Rewrite of deleteImage().
......................................................................


Patch Set 8: I would prefer that you didn't submit this

(3 inline comments)

....................................................
File vdsm/storage/blockSD.py
Line 176: def deleteVolumes(sdUUID, vols):
Line 177:     lvm.removeLVs(sdUUID, vols)
Line 178: 
Line 179: 
Line 180: def _zeroVolume(sdUUID, volUUID):
What do you mean by using "start"?
Line 181:     """Fill a block volume.
Line 182: 
Line 183:     This function requires an active LV.
Line 184:     """


Line 253:                 # TODO: Add the list of removed fail volumes to the exception.
Line 254:                 log.error("Remove failed for zeroed volumes: %s", e)
Line 255: 
Line 256: 
Line 257:     log.debug("VG:%s LVs: %s, img: %s", sdUUID, volUUIDs, imgUUID)
Why not log "toDelete" instead "of "volUUIDs" which contain whole volumes?
Line 258:     return
Line 259: 
Line 260: 
Line 261: class VGTagMetadataRW(object):


....................................................
File vdsm/storage/fileSD.py
Line 63: 
Line 64: 
Line 65: def getDomPath(sdUUID):
Line 66:     #  /rhev/data-center/mnt/export-path/sdUUID/dom_md/metadata
Line 67:     #  /rhev/data-center/mnt/blockSD/sdUUID/dom_md/metadata
I think the comment above is misleading.  The domPath returned by this function should be:

/rhev/data-center/mnt/export-path/sdUUID
/rhev/data-center/mnt/blockSD/sdUUID
Line 68:     pattern = os.path.join(sd.mountBasePath, '*', sdUUID)
Line 69:     # Warning! You need a global proc pool big as the number of NFS domains.
Line 70:     domPaths = getProcPool().glob.glob(pattern)
Line 71:     if len(domPaths) == 0:


--
To view, visit http://gerrit.ovirt.org/8506
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I304ff5cd70186ffc9789cd1ac9337efa6c5ff695
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>


More information about the vdsm-patches mailing list