Change in vdsm[master]: Applied PEP-8 guideline on code

zhshzhou at linux.vnet.ibm.com zhshzhou at linux.vnet.ibm.com
Wed Oct 31 08:56:48 UTC 2012


Zhou Zheng Sheng has posted comments on this change.

Change subject: Applied PEP-8 guideline on code
......................................................................


Patch Set 3: (2 inline comments)

....................................................
File vdsm/vm.py
Line 800: 
Line 801:         if newSize is None:
Line 802:             # newSize is always in megabytes
Line 803:             newSize = (config.getint('irs', 'volume_utilization_chunk_mb') +
Line 804:                        ((vmDrive.apparentsize + constants.MEGAB - 1) /
I'm do not agree with you Shao He, Here slash is the dividing operator.
Line 805:                         constants.MEGAB))
Line 806: 
Line 807:         if getattr(vmDrive, 'diskReplicate', None):
Line 808:             volInfo = {'poolID': vmDrive.diskReplicate['poolID'],


Line 1136:             return stats
Line 1137:         memUsage = 0
Line 1138:         realMemUsage = int(stats['memUsage'])
Line 1139:         if realMemUsage != 0:
Line 1140:             memUsage = (100 - float(realMemUsage) /
I'm do not agree with you Shao He, Here slash is the dividing operator.
Line 1141:                         int(self.conf['memSize']) * 100)
Line 1142:         stats['memUsage'] = utils.convertToStr(int(memUsage))
Line 1143:         stats['balloonInfo'] = self._getBalloonInfo()
Line 1144:         return stats


--
To view, visit http://gerrit.ovirt.org/8933
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b1ce77b01d848adb008d375decb2c214617ad2e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list