Change in vdsm[master]: netinfo: added configuration to show dummy NIC's too

asegurap at redhat.com asegurap at redhat.com
Tue Oct 30 10:53:59 UTC 2012


Antoni Segura Puimedon has posted comments on this change.

Change subject: netinfo: added configuration to show dummy NIC's too
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(1 inline comment)

Just a minor thing of PEP8:

_single_leading_underscore: weak "internal use" indicator. E.g. from M import * does not import objects whose name starts with an underscore.

....................................................
File vdsm/netinfo.py
Line 42: 
Line 43: LIBVIRT_NET_PREFIX = 'vdsm-'
Line 44: 
Line 45: 
Line 46: def __match_nic_name(nic, patterns):
It should be a single leading underscore.
Line 47:     return any(map(lambda p: fnmatch(nic, p), patterns))
Line 48: 
Line 49: def nics():
Line 50:     res = []


--
To view, visit http://gerrit.ovirt.org/8917
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica0ad974e6dd0d144a6bb0904fdcd6bbce99ff9f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Hercinger Viktor <hercinger.viktor at gmail.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Hercinger Viktor <hercinger.viktor at gmail.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>


More information about the vdsm-patches mailing list