Change in vdsm[master]: Add rescan to formatStorageDomain to solve multipath race

amureini at redhat.com amureini at redhat.com
Tue Oct 30 09:38:26 UTC 2012


Allon Mureinik has posted comments on this change.

Change subject: Add rescan to formatStorageDomain to solve multipath race
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/storage/hsm.py
Line 2269:         :param options: ?
Line 2270: 
Line 2271:         :returns: Nothing
Line 2272:         """
Line 2273:         multipath.rescan()
wouldn't you want to do this inside the lock?
Line 2274:         vars.task.setDefaultException(se.StorageDomainActionError("sdUUID=%s" % sdUUID))
Line 2275:         #getSharedLock(connectionsResource...)
Line 2276: 
Line 2277:         vars.task.getExclusiveLock(STORAGE, sdUUID)


--
To view, visit http://gerrit.ovirt.org/8921
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9525ce57d8d13b62cf56a3364e6eda9ec9c1a41d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>


More information about the vdsm-patches mailing list