Change in vdsm[master]: trivial: Some style fixes in API logging

zhshzhou at linux.vnet.ibm.com zhshzhou at linux.vnet.ibm.com
Tue Oct 30 06:18:39 UTC 2012


Zhou Zheng Sheng has posted comments on this change.

Change subject: trivial: Some style fixes in API logging
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(2 inline comments)

....................................................
Commit Message
Line 6: 
Line 7: trivial: Some style fixes in API logging
Line 8: 
Line 9: 1. Remove rebundant plus and trailing slash.
Line 10: 2. Add trailing space to avoid concatenating together.
Can I suggest "Add the missing space between the concatenated words." ?
Line 11: 
Line 12: Change-Id: I47e6ac04ca0bca2b02530ef60ba908714c7b45a4


....................................................
File vdsm/API.py
Line 176:                     self.log.error('Missing required parameter %s' % (param))
Line 177:                     return {'status': {'code': errCode['MissParam']
Line 178:                                                       ['status']['code'],
Line 179:                                        'message': ('Missing required '
Line 180:                                                    'parameter %s' % (param))}}
The line is continued automatically between { }, [ ], and ( ). If the added parentheses is just for line continuing, they would be useless here.  There are a few edits like this in the following code as well.

I think

'message': 'Missing required '
           'parameter %s' % (param)}}

is enough.
Line 181:             try:
Line 182:                 storage.misc.validateUUID(vmParams['vmId'])
Line 183:             except:
Line 184:                 return {'status': {'code': errCode['MissParam']


--
To view, visit http://gerrit.ovirt.org/8801
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I47e6ac04ca0bca2b02530ef60ba908714c7b45a4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list