Change in vdsm[master]: packaging: move /rhev/data-center to /var/lib/vdsm/data-cent...

dougsland at redhat.com dougsland at redhat.com
Tue Oct 30 01:23:54 UTC 2012


Douglas Schilling Landgraf has posted comments on this change.

Change subject: packaging: move /rhev/data-center to /var/lib/vdsm/data-center
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(3 inline comments)

Hello Alon,

Nice patch, few comments that need to be addresses. Please let me know if you want to /me continue it.

....................................................
File configure.ac
Line 74: AC_SUBST([vdsmbackupdir], ['${vdsmlogdir}/backup'])
Line 75: AC_SUBST([vdsmexecdir], ['${libexecdir}/vdsm'])
Line 76: AC_SUBST([vdsmhooksdir], ['${vdsmexecdir}/hooks'])
Line 77: AC_SUBST([vdsmtsdir], ['${sysconfdir}/pki/vdsm'])
Line 78: AC_SUBST([vdsmrepo], ['${vdsmlibdir}/data-center'])
What about use the full path here, as we were using? 

Here the error from make rpm:
============================
RPM build errors:
    File must begin with "/": ${vdsmlibdir}/data-center
    File must begin with "/": ${vdsmlibdir}/data-center/hsm-tasks
    File must begin with "/": ${vdsmlibdir}/data-center/mnt
Line 79: AC_SUBST([vdsmpylibdir], ['${pyexecdir}/vdsm'])
Line 80: AC_SUBST([vdsmtooldir], ['${vdsmpylibdir}/tool'])
Line 81: AC_SUBST([vdsmtestsdir], ['${datarootdir}/vdsm/tests'])
Line 82: 


....................................................
File vdsm/storage/fileSD.py
Line 63: 
Line 64: 
Line 65: def getDomUuidFromMetafilePath(metafile):
Line 66:     # Metafile path has pattern:
Line 67:     #  @vdsmlibdir@/data-center/mnt/export-path/sdUUID/dom_md/metadata
fileSD.py is not .in file, it won't replace @vdsmlibdir at .
Line 68: 
Line 69:     metaList = os.path.normpath(metafile).split('/')
Line 70:     return metaList[-3]
Line 71: 


....................................................
File vdsm/storage/fileVolume.py
Line 39: 
Line 40: 
Line 41: def getDomUuidFromVolumePath(volPath):
Line 42:     # Volume path has pattern:
Line 43:     #  @vdsmlibdir@/data-center/spUUID/sdUUID/images/imgUUID/volUUID
fileVolume.py is not .in file, it won't get replaced by @ macro @.
Line 44: 
Line 45:     # sdUUID position after data-center
Line 46:     sdUUIDPos = 3
Line 47: 


--
To view, visit http://gerrit.ovirt.org/8500
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4ed316fedbf2e4d7e5bf741b7c77a39704994ae7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ryan Harper <ryanh at us.ibm.com>


More information about the vdsm-patches mailing list