Change in vdsm[master]: Fix problem where a 0 error code will cause remoteFileHandle...

smizrahi at redhat.com smizrahi at redhat.com
Mon Oct 29 16:44:50 UTC 2012


Saggi Mizrahi has posted comments on this change.

Change subject: Fix problem where a 0 error code will cause remoteFileHandler to become a zombie
......................................................................


Patch Set 2: (2 inline comments)

....................................................
File tests/remoteFileHandlerTests.py
Line 75:                 print "fff"
Line 76:             except AssertionError:
Line 77:                 time.sleep(0.1)
Line 78:             else:
Line 79:                 return
If the proc entry was removed the process was reaped
Line 80: 


....................................................
File vdsm/storage/remoteFileHandler.py
Line 242: 
Line 243:         if not self.process.poll():
Line 244:             # For some reason Thread might have been released if python is
Line 245:             # going down. This makes sure that there are no issues when this
Line 246:             # happens
No one does
Line 247:             if Thread:
Line 248:                 t = Thread(target=self.process.wait)
Line 249:                 t.setDaemon(False)
Line 250:                 t.start()


--
To view, visit http://gerrit.ovirt.org/8907
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I738d9739673d11c15b882743d412b9b267013208
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>


More information about the vdsm-patches mailing list