Change in vdsm[master]: make vdsm/storage/hsm.py PEP8 clean

wudxw at linux.vnet.ibm.com wudxw at linux.vnet.ibm.com
Mon Oct 29 11:35:44 UTC 2012


Mark Wu has posted comments on this change.

Change subject: make vdsm/storage/hsm.py PEP8 clean
......................................................................


Patch Set 7: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File vdsm/storage/hsm.py
Line 1338:         """
Line 1339:         Delete a volume
Line 1340:         """
Line 1341:         argsStr = "sdUUID=%s, spUUID=%s, imgUUID=%s, volumes=%s, postZero=%s" \
Line 1342:                   ", force=%s" % (sdUUID, spUUID, imgUUID, volumes, postZero,
it's a little weird to start with comma.
Line 1343:                                   force)
Line 1344:         vars.task.setDefaultException(se.CannotDeleteVolume(argsStr))
Line 1345:         # Validates that the pool is connected. WHY?
Line 1346:         pool = self.getPool(spUUID)


--
To view, visit http://gerrit.ovirt.org/4530
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9b2f8b9e83db6f52678b4e0865668a79bcf53f5
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list