Change in vdsm[master]: Added a support for a guest hibernate command.

vfeenstr at redhat.com vfeenstr at redhat.com
Mon Oct 29 09:02:45 UTC 2012


Vinzenz Feenstra has posted comments on this change.

Change subject: Added a support for a guest hibernate command.
......................................................................


Patch Set 8: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/vm.py
Line 848:         return self._shutdownCommand('Powering down', int(timeout),
Line 849:             'sys_shutdown_timeout', self.guestAgent.desktopShutdown, timeout,
Line 850:             message)
Line 851: 
Line 852:     def hibernate(self, target='disk'):
Why don't you use here HibernateTarget.DISK as well? I don't understand why you introduced the constant and then use a literal here.
Line 853:         return self._shutdownCommand('Prepare for hibernate', 0,
Line 854:             'sys_hibernate_timeout', self.guestAgent.hibernate, target)
Line 855: 
Line 856:     def _shutdownCommand(self, event, timeout, timeout_var, command, *args):


--
To view, visit http://gerrit.ovirt.org/1121
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ad6836e61e9d91ec6f46a599541f61ff12e9737
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list