Change in vdsm[master]: itmap unit tests

ybronhei at redhat.com ybronhei at redhat.com
Mon Oct 29 08:40:34 UTC 2012


Yaniv Bronhaim has posted comments on this change.

Change subject: itmap unit tests
......................................................................


Patch Set 8: (1 inline comment)

....................................................
File tests/miscTests.py
Line 205:         data = frozenset([1, 2, 3, 4])
Line 206:         ret = frozenset(misc.itmap(dummy, data, 3))
Line 207:         self.assertEquals(ret, data)
Line 208: 
Line 209:     def testHowLong(self):
I just thought you wanted to know if the creation of the threads and processing the method don't delay more than 2 seconds... But when you put it that way, you'r right.. I'll add another test for that.

Here I just check that I don't spend to much time in itmap logic. maybe its redundant
Line 210:         def dummy(arg):
Line 211:             #  no sleep. (testing how long it takes to initiate the processes)
Line 212:             return arg
Line 213:         data = (1, 2, 3, 4)


--
To view, visit http://gerrit.ovirt.org/8746
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I26e258a035f49a8ecd57e992b9a68b9475a58839
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Hunt Xu <mhuntxu at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list