Change in vdsm[master]: Log if timed out during fileSD.scanDomains().

danken at redhat.com danken at redhat.com
Mon Oct 29 07:23:31 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Log if timed out during fileSD.scanDomains().
......................................................................


Patch Set 2: Looks good to me, approved

(1 inline comment)

even though commit message should not be so cryptic.

....................................................
Commit Message
Line 5: CommitDate: 2012-10-11 19:36:34 +0200
Line 6: 
Line 7: Log if timed out during fileSD.scanDomains().
Line 8: 
Line 9: git gr -i -E  'sd.*?\.produce\('
I take this to mean "there are too many produce()s, which makes fileSD.scanDomains() prone to Timouts, we should log it now, and avoid needless procude()s in a future patch".
Line 10: 
Line 11: Change-Id: I3af60f17b060d58c87260c744aecad21375cc25d


--
To view, visit http://gerrit.ovirt.org/8498
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3af60f17b060d58c87260c744aecad21375cc25d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>


More information about the vdsm-patches mailing list