Change in vdsm[master]: storage: Don't ignore nfs_mount_options in vdsm.conf

danken at redhat.com danken at redhat.com
Fri Oct 26 20:21:54 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: storage: Don't ignore nfs_mount_options in vdsm.conf
......................................................................


Patch Set 11: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File vdsm/caps.py
Line 296:             config.getint('vars', 'host_mem_reserve') +
Line 297:             config.getint('vars', 'extra_mem_reserve'))
Line 298:     caps['guestOverhead'] = config.get('vars', 'guest_ram_overhead')
Line 299: 
Line 300:     caps['alerts'] = _getAlerts()
any change to the api must be accompanied with a compatible change to vdsm_api/vdsmapi-schema.json
Line 301: 
Line 302:     return caps
Line 303: 
Line 304: 


Line 301: 
Line 302:     return caps
Line 303: 
Line 304: 
Line 305: def _getAlerts():
we tried hard to keep storage-specific know-how to the storage package. How about hiding this logic in a storage.getAlerts() functions? (some would say that it needs to be a declared hsm verb).
Line 306:     alerts = []
Line 307: 
Line 308:     # FIXME: Remove when nfs_mount_options is no longer supported
Line 309:     nfs_config = config.get('irs', 'nfs_mount_options')


--
To view, visit http://gerrit.ovirt.org/5368
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3c1d13bfd98a9b41b9728bdcb7f01b3161c26bd8
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list