Change in vdsm[master]: pep8: fix 2 errors and ignore plenty of others

zhshzhou at linux.vnet.ibm.com zhshzhou at linux.vnet.ibm.com
Thu Oct 25 07:31:12 UTC 2012


Zhou Zheng Sheng has posted comments on this change.

Change subject: pep8: fix 2 errors and ignore plenty of others
......................................................................


Patch Set 2: Looks good to me, but someone else must approve

Build success. pydiff finds some changes, they are about change "==" and "!=" to "is" and "is not" when compared to "True" or "None".

In fact some of these changes affects the logic, because Python says:
  >>> 1 == True
  True
  >>> 1 is True
  False

This means we become more strict of boolean types. I think it's OK.

--
To view, visit http://gerrit.ovirt.org/8753
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc46a3a8600301dd33f3f170c1e85810dc554a33
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list