Change in vdsm[master]: add -d parameter when umouning in mk_sysprep_floppy

danken at redhat.com danken at redhat.com
Wed Oct 24 19:16:59 UTC 2012


Dan Kenigsberg has submitted this change and it was merged.

Change subject: add -d parameter when umouning in mk_sysprep_floppy
......................................................................


add -d parameter when umouning in mk_sysprep_floppy

After umounting mntpoint successfully, it doesn't free automatically
the loop device. Here, we add '-d' parameter to free the device to
prevent it using up all loop devices.

The issue only happened in the special case that node is built using
livecd-tools(version: >= 16.8-1) and rpms from centos63. Because:
1. Centos63 disables auto-destruction feature and still depends on
  /etc/mtab to free the loop device.
2. Livecd-tools links /etc/mtab to /proc/self/mounts, so umount can't
  get suggestion to free the loop device from /etc/mtab.

Change-Id: I70e802b9062e586b10937c700f9a481bf1fe51b0
Signed-off-by: jarod.w <work.iec23801 at gmail.com>
---
M vdsm/mk_sysprep_floppy.in
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Hunt Xu: Looks good to me, but someone else must approve
  Gal Hammer: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Jarod.w: Verified


--
To view, visit http://gerrit.ovirt.org/8770
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I70e802b9062e586b10937c700f9a481bf1fe51b0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Jarod.w <work.iec23801 at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Hunt Xu <mhuntxu at gmail.com>
Gerrit-Reviewer: Jarod.w <work.iec23801 at gmail.com>


More information about the vdsm-patches mailing list