Change in vdsm[master]: itmap starts threads for each argument causes too many oop o...

danken at redhat.com danken at redhat.com
Wed Oct 24 19:12:15 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: itmap starts threads for each argument causes too many oop operations
......................................................................


Patch Set 4: Looks good to me, approved

(1 inline comment)

....................................................
File vdsm/storage/misc.py
Line 1283:                 # greater than 1
Line 1284:                 if threadsCount < 1:
Line 1285:                     raise RuntimeError("No thread initiated")
Line 1286:                 else:
Line 1287:                     yield respQueue.get()
There's a minor issue here: if the caller of itmap() performs a long operation in each "yield", we loose time that could have been spent on issuing a new threads.

Still I think that's good enough for our use case.
Line 1288:                     # if yield returns one thread stopped, so we can run
Line 1289:                     # another thread in queue
Line 1290:                     maxthreads += 1
Line 1291:                     threadsCount -= 1


--
To view, visit http://gerrit.ovirt.org/8745
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2877c28b916475aead16d47d37522c2bf44cc16
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Hunt Xu <mhuntxu at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list