Change in vdsm[master]: Adding supervdsm unit tests
agl at us.ibm.com
agl at us.ibm.com
Wed Oct 24 17:07:41 UTC 2012
Adam Litke has posted comments on this change.
Change subject: Adding supervdsm unit tests
......................................................................
Patch Set 8: (2 inline comments)
....................................................
File vdsm/supervdsm.py
Line 90
Line 91
Line 92
Line 93
Line 94
All I am asking is for you to explain here in the code why we have made these instance variables. As a reviewer, I am telling you that I find that to be important for code readability.
....................................................
File vdsm/supervdsmServer.py
Line 376:
Line 377: log.debug("Started serving super vdsm object")
Line 378: servThread.join()
Line 379: except Exception as e:
Line 380: log.error("Could not start Super Vdsm: %s", e)
The diff shows what it was before. This change is completely unrelated to making supervdsm testable.
Further, it prints exception information in a way that this community has decided should be deprecated.
I am simply pointing out these two facts. I give -1's when I feel a patch has an issue that needs to be resolved. I am not insulting your idea. When the issues are fixed I will +1 your patch.
Line 381: sys.exit(1)
Line 382: finally:
Line 383: try:
Line 384: if address is not None and os.path.exists(address):
--
To view, visit http://gerrit.ovirt.org/8600
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I08880b12db8a6ca9cc57d74d2ef2a86980a5b097
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
More information about the vdsm-patches
mailing list