Change in vdsm[master]: Fix string format in storage exception

shaohef at linux.vnet.ibm.com shaohef at linux.vnet.ibm.com
Wed Oct 24 10:08:32 UTC 2012


ShaoHe Feng has uploaded a new change for review.

Change subject: Fix string format in storage exception
......................................................................

Fix string format in storage exception

Change-Id: I3bf1c27f2e2ca0d14e9fadca93c6184188a81541
Signed-off-by: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
---
M vdsm/storage/sp.py
M vdsm/storage/volume.py
2 files changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/66/8766/1

diff --git a/vdsm/storage/sp.py b/vdsm/storage/sp.py
index e746a88..9a60390 100644
--- a/vdsm/storage/sp.py
+++ b/vdsm/storage/sp.py
@@ -1826,7 +1826,7 @@
                 img.delete(sdUUID=sdUUID, imgUUID=templateImage, postZero=postZero,
                             force=force)
             elif not dom.isBackup():
-                raise se.ImagesActionError("Can't remove template with children %s",
+                raise se.ImagesActionError("Can't remove template with children %s" %
                                         allVols)
             else:
                 # Removing a template with dependencies in backup domain
diff --git a/vdsm/storage/volume.py b/vdsm/storage/volume.py
index b9eb356..85ea95f 100644
--- a/vdsm/storage/volume.py
+++ b/vdsm/storage/volume.py
@@ -483,8 +483,8 @@
             raise
         except Exception, e:
             cls.log.error("Unexpected error", exc_info=True)
-            raise se.VolumeCreationError("Volume creation %s failed: %s",
-                                         volUUID, e)
+            raise se.VolumeCreationError("Volume creation %s failed: %s" %
+                                         (volUUID, e))
 
         # Remove the rollback for the halfbaked volume
         vars.task.replaceRecoveries(


--
To view, visit http://gerrit.ovirt.org/8766
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3bf1c27f2e2ca0d14e9fadca93c6184188a81541
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list