Change in vdsm[master]: add -d parameter when umouning in mk_sysprep_floppy

Jarod.w work.iec23801 at gmail.com
Wed Oct 24 04:09:31 UTC 2012


Jarod.w has posted comments on this change.

Change subject: add -d parameter when umouning in mk_sysprep_floppy
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/mk_sysprep_floppy.in
Line 32: /sbin/mkfs.msdos -C "$FLOPPY_NAME" 1440
Line 33: /bin/chown @VDSMUSER@:@QEMUGROUP@ "$FLOPPY_NAME"
Line 34: /bin/chmod 0440 "$FLOPPY_NAME"
Line 35: mntpoint=`mktemp -d`
Line 36: mount -o loop,uid=`id -u`,gid=`id -g` "$FLOPPY_DIR/$FLOPPY_NAME" $mntpoint
Later, I'll send other patch to delete the useless $FLOPPY_DIR
Line 37: 
Line 38: /bin/cat > $mntpoint/sysprep.inf
Line 39: 
Line 40: umount -d $mntpoint


--
To view, visit http://gerrit.ovirt.org/8675
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If3f964b50a38e8dc180d20f7e6687a092b7dc272
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Jarod.w <work.iec23801 at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jarod.w <work.iec23801 at gmail.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>


More information about the vdsm-patches mailing list