Change in vdsm[master]: NIC hotplug should fail if setPortMirroring failed

wudxw at linux.vnet.ibm.com wudxw at linux.vnet.ibm.com
Wed Oct 24 03:58:26 UTC 2012


Mark Wu has posted comments on this change.

Change subject: NIC hotplug should fail if setPortMirroring failed
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/libvirtvm.py
Line 1482:             # In any case we need below rollback for all kind of failures.
Line 1483:             except Exception, e:
Line 1484:                 self.log.error("setPortMirroring for network %s failed",
Line 1485:                                 network, exc_info=True)
Line 1486:                 nicParams['portMirroring'] = mirroredNetworks
It seems hotunlugNic uses the 'portMirroring' attribute of LibvirtVmDevice in _devices[vm.NIC_DEVICES], not the value in nicParams. So even if you pass the mirrored networks to it, it will still try to unset the un-mirrored network.
Line 1487:                 self.hotunplugNic({'nic': nicParams})
Line 1488:                 return {'status':
Line 1489:                         {'code': errCode['hotplugNic']['status']['code'],
Line 1490:                          'message': e.message}}


--
To view, visit http://gerrit.ovirt.org/8742
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If1b62fdec5f2c1a462283ff591d24e7b6f526f9e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Meni Yakove <myakove at redhat.com>


More information about the vdsm-patches mailing list