Change in vdsm[master]: Make netinfoTests follow closely python guidelines.

danken at redhat.com danken at redhat.com
Tue Oct 23 23:02:44 UTC 2012


Dan Kenigsberg has submitted this change and it was merged.

Change subject: Make netinfoTests follow closely python guidelines.
......................................................................


Make netinfoTests follow closely python guidelines.

Change 'file' by 'open' and use a with block not to wait for gc.
Prefer list comprehensions to map and filter.

Change-Id: Ie4774eb1c89914f2bb77db3cb25d8266fcf1f060
Signed-off-by: Antoni S. Puimedon <asegurap at redhat.com>
---
M tests/netinfoTests.py
1 file changed, 7 insertions(+), 5 deletions(-)

Approvals:
  Adam Litke: Looks good to me, but someone else must approve
  Mark Wu: Looks good to me, but someone else must approve
  Dan Kenigsberg: Verified; Looks good to me, approved
  Igor Lvovsky: Looks good to me, but someone else must approve


--
To view, visit http://gerrit.ovirt.org/8717
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie4774eb1c89914f2bb77db3cb25d8266fcf1f060
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list