Change in vdsm[master]: itmap unit tests

shaohef at linux.vnet.ibm.com shaohef at linux.vnet.ibm.com
Tue Oct 23 16:04:59 UTC 2012


ShaoHe Feng has posted comments on this change.

Change subject: itmap unit tests
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File tests/miscTests.py
Line 201:         def dummy(arg):
Line 202:             time.sleep(1)
Line 203:             return arg
Line 204:         data = [1, 2, 3, 4]
Line 205:         self.assertEquals(list(misc.itmap(dummy, data, 3)), data)
from you depends patch, http://gerrit.ovirt.org/#/c/8745/1/vdsm/storage/misc.py.
the doc string of itmap says that the result is not in any particular order.
so now you assert the result was in a particular order.
Line 206: 
Line 207:     def testMoreThreadsThanArgs(self):
Line 208:         data = [1, 2, 3]
Line 209:         self.assertEquals(list(misc.itmap(int, data, 80)), data)


--
To view, visit http://gerrit.ovirt.org/8746
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I26e258a035f49a8ecd57e992b9a68b9475a58839
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list