Change in vdsm[master]: pep8: clean few small files

zhshzhou at linux.vnet.ibm.com zhshzhou at linux.vnet.ibm.com
Tue Oct 23 02:51:34 UTC 2012


Zhou Zheng Sheng has posted comments on this change.

Change subject: pep8: clean few small files
......................................................................


Patch Set 1: (1 inline comment)

When I run 'make rpm', it reports the following error:

make  check-local
make[3]: Entering directory `/root/rpmbuild/BUILD/vdsm-4.10.1'
find . -path './.git' -prune -type f -o \
	-name '*.py' -o -name '*.py.in'  | xargs /usr/bin/pyflakes
/usr/bin/pep8 --exclude="restData.py" --filename '*.py,*.py.in' \
	tests vdsm-tool vdsm/API.py vdsm/BindingXMLRPC.py vdsm/SecureXMLRPCServer.py vdsm/blkid.py vdsm/caps.py vdsm/clientIF.py vdsm/config.py.in vdsm/configNetwork.py vdsm/constants.py.in vdsm/debugPluginClient.py vdsm/define.py vdsm/exception.py vdsm/gluster vdsm/guestIF.py vdsm/hooks.py vdsm/kaxmlrpclib.py vdsm/ksm.py vdsm/libvirtev.py vdsm/libvirtvm.py vdsm/lsblk.py vdsm/md_utils.py vdsm/momIF.py vdsm/neterrors.py vdsm/netinfo.py vdsm/parted_utils.py vdsm/rest/BindingREST.py vdsm/rest/Controller.py vdsm/storage/blockVolume.py vdsm/storage/devicemapper.py vdsm/storage/domainMonitor.py vdsm/storage/fileSD.py vdsm/storage/fileUtils.py vdsm/storage/fileVolume.py vdsm/storage/fuser.py vdsm/storage/hba.py vdsm/storage/iscsiadm.py vdsm/storage/imageRepository vdsm/storage/localFsSD.py vdsm/storage/lvm.py vdsm/storage/misc.py vdsm/storage/mount.py vdsm/storage/multipath.py vdsm/storage/nfsSD.py vdsm/storage/outOfProcess.py vdsm/storage/persistentDict.py vdsm/storage/resourceFactories.!
 py vdsm/storage/sd.py vdsm/storage/securable.py vdsm/storage/storage_exception.py vdsm/storage/task.py vdsm/storage/taskManager.py vdsm/storage/volume.py vdsm/substitute_constants.py vdsm/supervdsm.py vdsm/supervdsmServer.py vdsm/tc.py vdsm/vdsm vdsm_cli vdsm_hooks/fileinject vdsm_hooks/promisc/after_vm_start.py vdsm_hooks/scratchpad vdsm_hooks/sriov/before_vm_start.py vdsm_hooks/vhostmd vdsm_reg/createDaemon.py vdsm_reg/define.py vds_bootstrap/miniyum.py 
Traceback (most recent call last):
  File "/usr/bin/pep8", line 9, in <module>
    load_entry_point('pep8==1.0.1', 'console_scripts', 'pep8')()
  File "/usr/lib/python2.7/site-packages/pep8.py", line 1348, in _main
    runner(path)
  File "/usr/lib/python2.7/site-packages/pep8.py", line 1023, in input_file
    errors = Checker(filename).check_all()
  File "/usr/lib/python2.7/site-packages/pep8.py", line 823, in __init__
    self.lines = readlines(filename)
  File "/usr/lib/python2.7/site-packages/pep8.py", line 726, in readlines
    return open(filename).readlines()
IOError: [Errno 2] No such file or directory: 'vdsm/substitute_constants.py'

I notice that vdsm/substitute_constants.py is not in vdsm/Makefile.am. This may be the cause.

....................................................
File Makefile.am
Line 62: 	vdsm/libvirtvm.py \
Line 63: 	vdsm/lsblk.py \
Line 64: 	vdsm/md_utils.py \
Line 65: 	vdsm/momIF.py \
Line 66: 	vdsm/neterrors.py \
This file is not modified in this patch, but it's already PEP 8 clean, so adding it to the list is OK.

However I notice that vdsm/vdsmDebugPlugin.py is modified in the patch but not added to the list.
Line 67: 	vdsm/netinfo.py \
Line 68: 	vdsm/parted_utils.py \
Line 69: 	vdsm/rest/BindingREST.py \
Line 70: 	vdsm/rest/Controller.py \


--
To view, visit http://gerrit.ovirt.org/8711
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5326e6fb6a22979ab7d6cd6d4e61af746e9a6dd8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list