Change in vdsm[master]: BZ#855924 fix VM config dictionary

peet at redhat.com peet at redhat.com
Mon Oct 22 17:08:11 UTC 2012


Peter V. Saveliev has posted comments on this change.

Change subject: BZ#855924 fix VM config dictionary
......................................................................


Patch Set 4: (1 inline comment)

....................................................
File vdsm/vm.py
Line 214:         items and set them up as full paths
Line 215:         """
Line 216:         # care only about "drives" list, since
Line 217:         # "devices" doesn't cause errors
Line 218:         if 'drives' in self._vm.conf.keys():
fixed, checked on the teststand and with timeit
Line 219:             for item in ("cdrom", "floppy"):
Line 220:                 new_drives = []
Line 221:                 for drive in self._vm.conf['drives']:
Line 222:                     if drive['device'] == item:


--
To view, visit http://gerrit.ovirt.org/8627
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I33e957f8daac4266d9e19cc008cf830bd395fffe
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>


More information about the vdsm-patches mailing list