Change in vdsm[master]: BZ#855924 fix VM config dictionary
ilvovsky at redhat.com
ilvovsky at redhat.com
Mon Oct 22 12:38:51 UTC 2012
Igor Lvovsky has posted comments on this change.
Change subject: BZ#855924 fix VM config dictionary
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File vdsm/vm.py
Line 219: for drive in self._vm.conf['drives']:
Line 220: if drive['device'] == item:
Line 221: self._vm.conf[item] = drive['path']
Line 222: self._vm.conf['drives'].pop(
Line 223: self._vm.conf['drives'].index(drive))
why you need to pop cdrom/floppy from devices?
noone using 'devices' in 3.0
Line 224:
Line 225: def run(self):
Line 226: try:
Line 227: mstate = ''
--
To view, visit http://gerrit.ovirt.org/8627
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I33e957f8daac4266d9e19cc008cf830bd395fffe
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
More information about the vdsm-patches
mailing list