Change in vdsm[master]: Adding hooks support for NIC hotplug

danken at redhat.com danken at redhat.com
Mon Oct 22 08:32:00 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Adding hooks support for NIC hotplug
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(2 inline comments)

I'm sorry that it took me so long to review this patch, but I have two relatively minor concerns.

....................................................
File vdsm/libvirtvm.py
Line 1514:             return {
Line 1515:                 'status': {'code': errCode['hotunplugNic']['status']['code'],
Line 1516:                            'message': e.message}}
Line 1517: 
Line 1518:         hooks.after_nic_unplug(nicXml, self.conf)
naming is a bit asymmetrical: why unplog is not "hot"?
Line 1519:         return {'status': doneCode, 'vmList': self.status()}
Line 1520: 
Line 1521:     def hotplugDisk(self, params):
Line 1522:         if self.isMigrating():


....................................................
File vdsm/vdsmd.8.in
Line 57: .SS Hook environment
Line 58: Each hook script (except before_vdsm_start and after_vdsm_stop) inherit the
Line 59: environment of the VDSM process, with an additional variable
Line 60: .B _hook_domxml
Line 61: which holds the path of libvirt's
this is not exact for the new hooks - the nic xml is passed here.

I find the naming a bit awkward. Maybe these 3 hooks should use _hook_nicxml. At the least, this peculiarity has to be documented.
Line 62: .B domain xml
Line 63: representation of the relevant virtual machine.
Line 64: The uuid of the virtual machine may be deduced from that xml, but it is also
Line 65: available as the environment variable


--
To view, visit http://gerrit.ovirt.org/7224
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I253104ee9831a881e2fb06f0a658631662611d77
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Itzik Brown <itzikb at mellanox.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Itzik Brown <itzikb at mellanox.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list