Change in vdsm[master]: pool: live storage migration implementation

abaron at redhat.com abaron at redhat.com
Sat Oct 20 19:07:35 UTC 2012


Ayal Baron has posted comments on this change.

Change subject: pool: live storage migration implementation
......................................................................


Patch Set 17: (1 inline comment)

....................................................
File vdsm/vm.py
Line 729:         self.log.debug('new rtc offset %s', timeOffset)
Line 730:         self.conf['timeOffset'] = timeOffset
Line 731: 
Line 732:     def extendDriveVolume(self, vmDrive, newSize=None):
Line 733:         if not vmDrive.blockDev:
so does this skip direct LUNs or not?
Line 734:             return
Line 735: 
Line 736:         if newSize is None:
Line 737:             # newSize is always in megabytes


--
To view, visit http://gerrit.ovirt.org/5252
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I91e641cb1d25feb8a406aa7ad07415587a7ac290
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list