Change in vdsm[master]: add createVm support of cputune

lvroyce at linux.vnet.ibm.com lvroyce at linux.vnet.ibm.com
Fri Oct 19 08:00:04 UTC 2012


Royce Lv has posted comments on this change.

Change subject: add createVm support of cputune
......................................................................


Patch Set 3: (2 inline comments)

In the new version I just leave libvirt to care the default value to distinguish the situation we set 'tune' or not. Is that Ok?

....................................................
File vdsm_api/vdsmapi-schema.json
Line 2336:           'display': 'VmDisplayType', 'displayIp': 'str',
Line 2337:           'displayPort': 'uint', 'displaySecurePort': 'uint',
Line 2338:           'emulatedMachine': 'str', 'keyboardLayout': 'str',
Line 2339:           'kvmEnable': 'bool', 'memSize': 'uint',
Line 2340:           'nicModel': 'str', 'pauseCode': 'str',
Done
Line 2341:           'pid': 'uint', 'smp': 'uint', '*smpCoresPerSocket': 'uint',
Line 2342:           '*smpThreadsPerCore': 'uint', 'status': 'VmStatus',
Line 2343:           'timeOffset': 'uint', 'transparentHugePages': 'bool',
Line 2344:           'vmId': 'UUID', 'vmName': 'str', 'vmType': 'VmType'}}


....................................................
File vdsm/libvirtvm.py
Line 737:         self.dom.appendChild(cpu)
Line 738: 
Line 739:     def appendTunable(self):
Line 740:         cputune = self.doc.createElement('cputune')
Line 741:         cputuneParams = {'shares': '1024'}
Ryan,
For the default nice we use:
nice = int(self.conf.get('nice', '0'))

looked into the code and see this not preserved in conf.But I total agree with you on that because we need to query the live tune value so we need to keep it in conf.
Line 742:         # keep 'cpuTune' and 'cpuPinning' for engine bc.
Line 743:         if 'cpuTune' in self.conf:
Line 744:             cputuneParams = self.conf['cpuTune']
Line 745:         if 'cpuPinning' in self.conf:


--
To view, visit http://gerrit.ovirt.org/8445
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76e9b9d291d4801965163774ba45d15b39a77471
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Ryan Harper <ryanh at us.ibm.com>


More information about the vdsm-patches mailing list