Change in vdsm[master]: Related to 846307 - Simplifying clientIF._cleanOldFiles().
danken at redhat.com
danken at redhat.com
Thu Oct 18 22:32:31 UTC 2012
Dan Kenigsberg has posted comments on this change.
Change subject: Related to 846307 - Simplifying clientIF._cleanOldFiles().
......................................................................
Patch Set 8: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/clientIF.py
Line 453: return None
Line 454:
Line 455: def _cleanOldFiles(self):
Line 456: known_exts = ("guest.socket", "pid", "recovery")
Line 457: dontDel = ("vdsmd.pid", "respawn.pid", "svdsm.pid", "svdsm.sock")
please drop "svdsm.sock", it does not have one of the known_exts.
Line 458:
Line 459: fNames = [fName for fName in os.listdir(constants.P_VDSM_RUN)
Line 460: if fName not in dontDel]
Line 461: for fName in fNames:
Line 466:
Line 467: if fileExt in known_exts and vmId not in self.vmContainer:
Line 468: fPath = os.path.join(constants.P_VDSM_RUN, fName)
Line 469: try:
Line 470: utils.rmFile(constants.P_VDSM_RUN + fName)
fpath was already created one line above.
Line 471: except OSError:
--
To view, visit http://gerrit.ovirt.org/8626
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd63a1f4b1c64f84d5734da033a2420b97ce0ada
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
More information about the vdsm-patches
mailing list