Change in vdsm[master]: Update scsi_id options format and add devices to multipath.c...

danken at redhat.com danken at redhat.com
Thu Oct 18 15:53:36 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Update scsi_id options format and add devices to multipath.conf
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File vdsm/constants.py.in
Line 157: #
Line 158: STRG_ISCSI_HOST = "iscsi_host/"
Line 159: STRG_SCSI_HOST = "scsi_host/"
Line 160: STRG_ISCSI_SESSION = "iscsi_session/"
Line 161: STRG_MPATH_CONF = (
I see that there's a mess here, only because of pep8.

maybe it is a sign that this	STRG_MPATH_CONF should be dropped from constants, and moved into its own data-only file.
Line 162: "\n\n"
Line 163: "defaults {\n"
Line 164: "    polling_interval        5\n"
Line 165: "    getuid_callout          \"@SCSI_ID_PATH@ --whitelisted "


--
To view, visit http://gerrit.ovirt.org/8363
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I088ff2d4ff600ec9c1e784a43f3336e36ceb717d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>


More information about the vdsm-patches mailing list