Change in vdsm[master]: volume: remove domain shared lock from getVolumeSize

fsimonce at redhat.com fsimonce at redhat.com
Thu Oct 18 12:43:52 UTC 2012


Federico Simoncelli has posted comments on this change.

Change subject: volume: remove domain shared lock from getVolumeSize
......................................................................


Patch Set 2:

> But what about removing storage domain while an lv is held by one of these methods?
> Wouldn't it leave the domain half-dead?

By "held" you mean the lvm internal per-host locking mechanism? (Or something else?)  It indefinitely waits on a flock, so either you get the volume size before it's removed or you get an error after it is removed. If the lvs gets stuck (holding the flock) then I assume the lvremove would have got stuck too.

--
To view, visit http://gerrit.ovirt.org/8517
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I644fff245b62ef009a4ca7b6f4a903c9ffcc9653
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ryan Harper <ryanh at us.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list