Change in vdsm[master]: schema: New type VmParameters

lvroyce at linux.vnet.ibm.com lvroyce at linux.vnet.ibm.com
Thu Oct 18 06:12:58 UTC 2012


Royce Lv has posted comments on this change.

Change subject: schema: New type VmParameters
......................................................................


Patch Set 4:

Adam,
 I saw 3 kinds of vm related description spread in the code:

(1)vm.conf: query via vm.status()(vm.py), used as return value when changed vm's conf(changeCD, hotplugDisk)

(2)vm.stats: query via vm.getStats()(vm.py), which is VM's live stats and used when calling getVmStats.(also used by MOM)

(3)vm.parameter: parameter passed to vm.create().(API.py)

You are trying to split is (3) from (1); But the live info should be (2) from (1) according to me.

--
To view, visit http://gerrit.ovirt.org/7839
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I00d1b9aed55cbfc2210c1a4091bce17d45b90e67
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list