Change in vdsm[master]: Adding supervdsm uts

danken at redhat.com danken at redhat.com
Wed Oct 17 19:54:33 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Adding supervdsm uts
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File tests/superVdsmTests.py
Line 17:         self._origintimestempfile = self._proxy.timestamp
Line 18:         self._originsock = self._proxy.address
Line 19: 
Line 20:         # temporary values to run temporary svdsm
Line 21:         self._proxy.pidfile = tempfile.mkstemp()[1]
Saggi is refering to the [0] element of the return value. If you do not close it, you leak file descriptors, until the process ends. It's not the end of the world for a unit test, but it is a bad practice that we do not want to promote.
Line 22:         self._proxy.timestamp = tempfile.mkstemp()[1]
Line 23:         self._proxy.address = tempfile.mkstemp()[1]
Line 24: 
Line 25:     def tearDown(self):


--
To view, visit http://gerrit.ovirt.org/8600
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08880b12db8a6ca9cc57d74d2ef2a86980a5b097
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>


More information about the vdsm-patches mailing list