Change in vdsm[master]: Related to 846307 - Simplifying clientIF._cleanOldFiles().

smizrahi at redhat.com smizrahi at redhat.com
Wed Oct 17 17:17:18 UTC 2012


Saggi Mizrahi has posted comments on this change.

Change subject: Related to 846307 - Simplifying clientIF._cleanOldFiles().
......................................................................


Patch Set 6: (1 inline comment)

....................................................
File vdsm/clientIF.py
Line 456:         known_exts = ("guest.socket", "pid", "recovery")
Line 457:         dontDel = ("vdsmd.pid", "respawn.pid", "svdsm.pid", "svdsm.sock")
Line 458: 
Line 459:         fNames = [fName for fName in os.listdir(constants.P_VDSM_RUN)
Line 460:                                                     if fName not in dontDel]
Could be a generator instead of a list
Line 461:         for fName in fNames:
Line 462:             try:
Line 463:                 vmId, fileExt = fName.split(".", 1)
Line 464:             except ValueError:


--
To view, visit http://gerrit.ovirt.org/8626
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd63a1f4b1c64f84d5734da033a2420b97ce0ada
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>


More information about the vdsm-patches mailing list