Change in vdsm[master]: Handling removing file Exceptions.
agl at us.ibm.com
agl at us.ibm.com
Wed Oct 17 17:03:37 UTC 2012
Adam Litke has posted comments on this change.
Change subject: Handling removing file Exceptions.
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/utils.py
Line 65: logging.warning("File: %s already removed", fileToRemove)
Line 66: else:
Line 67: logging.error("Removing file: %s failed", fileToRemove,
Line 68: exc_info=True)
Line 69: raise
As Dan mentioned in an earlier patch series, you don't need to log here because you are raising the exception.
Line 70:
Line 71: def readMemInfo():
Line 72: """
Line 73: Parse ``/proc/meminfo`` and return its content as a dictionary.
--
To view, visit http://gerrit.ovirt.org/8625
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If76e158ad69921d382e3d42ae45486534b9379f9
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
More information about the vdsm-patches
mailing list