Change in vdsm[master]: schema: New type VmParameters

lvroyce at linux.vnet.ibm.com lvroyce at linux.vnet.ibm.com
Wed Oct 17 08:12:58 UTC 2012


Royce Lv has posted comments on this change.

Change subject: schema: New type VmParameters
......................................................................


Patch Set 4:

Adam,
As far as to me, vmparams is subset of  vm.conf as we  do :self.conf.update(params) in vm.__init__.

I agree with you that such as 'pid' and 'clientIP' in vmparams will make no sense. 
All the feild in vmparams will be need in vm.conf, so shall we make vmParams a data element of vmDefinition?

--
To view, visit http://gerrit.ovirt.org/7839
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I00d1b9aed55cbfc2210c1a4091bce17d45b90e67
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list