Change in vdsm[master]: make vdsm/kaxmlrpclib.py PEP 8 clean
danken at redhat.com
danken at redhat.com
Tue Oct 16 15:18:14 UTC 2012
Dan Kenigsberg has posted comments on this change.
Change subject: make vdsm/kaxmlrpclib.py PEP 8 clean
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/kaxmlrpclib.py
Line 94: self.sock = None
Line 95: continue
Line 96: break
Line 97: if not self.sock:
Line 98: raise socket.error, msg
I think it's not very clear now. I'd prefer to have here
## beginning of added code
..
Line 99: self.sock.setsockopt(socket.SOL_SOCKET, socket.SO_KEEPALIVE, 1)
Line 100: # added
Line 101: self.sock.setsockopt(socket.SOL_TCP, socket.TCP_KEEPIDLE, KEEPIDLE)
Line 102: # added
Line 102: # added
Line 103: self.sock.setsockopt(socket.SOL_TCP, socket.TCP_KEEPINTVL, KEEPINTVL)
Line 104: # added
Line 105: self.sock.setsockopt(socket.SOL_TCP, socket.TCP_KEEPCNT, KEEPCNT)
Line 106: # added
... and
# end of added code
here
Line 107:
Line 108:
Line 109: class TcpkeepHTTP(httplib.HTTP):
Line 110: _connection_class = TcpkeepHTTPConnection
--
To view, visit http://gerrit.ovirt.org/8597
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e8d011a0b74d70e3b6609ed380cef8f5b67ec9c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: Bing Bu Cao <mars at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
More information about the vdsm-patches
mailing list