Change in vdsm[master]: make vdsm/storage/hsm.py PEP8 clean

zhshzhou at linux.vnet.ibm.com zhshzhou at linux.vnet.ibm.com
Tue Oct 16 06:40:56 UTC 2012


Zhou Zheng Sheng has posted comments on this change.

Change subject: make vdsm/storage/hsm.py PEP8 clean
......................................................................


Patch Set 4: Verified; Looks good to me, but someone else must approve

pydiff found 4 differences, all are acceptable. The detailed report:

 pydiff hsm*.py
 4 difference(s)
 first file: hsmo.py
 second file: hsm.py

((1586,
  "CallFunc(Getattr(Name('path'), 'has_key'), [Const('hbtl')], None, None)"),
 (1709, "Compare(Const('hbtl'), [('in', Name('path'))])"))

((1708, '=='), (1838, 'is'))

((1709,
  "Compare(CallFunc(Name('type'), [Name('force')], None, None), [('==', CallFunc(Name('type'), [Const('')], None, None))])"),
 (1838,
  "CallFunc(Name('isinstance'), [Name('force'), Name('str')], None, None)"))

((1992,
  "CallFunc(Getattr(Name('conDef'), 'has_key'), [Const('initiatorName')], None, None)"),
 (2122, "Compare(Const('initiatorName'), [('in', Name('conDef'))])"))

--
To view, visit http://gerrit.ovirt.org/4530
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9b2f8b9e83db6f52678b4e0865668a79bcf53f5
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list