Change in vdsm[master]: image: copying a template is always allowed

shuming at linux.vnet.ibm.com shuming at linux.vnet.ibm.com
Mon Oct 15 16:14:48 UTC 2012


Shu Ming has posted comments on this change.

Change subject: image: copying a template is always allowed
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File vdsm/storage/hsm.py
Line 1339: 
Line 1340:         # Validates that the pool is connected. WHY?
Line 1341:         pool = self.getPool(spUUID)
Line 1342: 
Line 1343:         if op != image.COPY_OP:
But validateImageDelete() was called in the if condition block, it is implicitly saying that if the op is not COPY_OP, it should be a MOVE_OP.
Line 1344:             self.validateImageDelete(srcDom, srcAllVols, imgUUID)
Line 1345: 
Line 1346:         self.validateImageCopy(srcAllVols, dstDom, imgUUID)
Line 1347: 


--
To view, visit http://gerrit.ovirt.org/8408
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e07d569eec02ac4dcd386a7c576342f640ec242
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list