Change in vdsm[master]: Adding new resourceFactory that only opens fd

smizrahi at redhat.com smizrahi at redhat.com
Mon Oct 15 15:43:34 UTC 2012


Saggi Mizrahi has posted comments on this change.

Change subject: Adding new resourceFactory that only opens fd
......................................................................


Patch Set 10: I would prefer that you didn't submit this

(8 inline comments)

....................................................
File vdsm/storage/blockVolume.py
Line 88:         self.volWatcherNamespace = rf.VOLUME_WATCHER_NAMESPACE
Line 89:         try:
Line 90:             rmanager.registerNamespace(self.volWatcherNamespace,
Line 91:                                        volWatcherFactory)
Line 92:         except Exception:
No need to log as it is expected behavior.
Line 93:             self.log.warn("Resource namespace %s already registered",
Line 94:                           self.volWatcherNamespace)
Line 95: 
Line 96:     def validate(self):


Line 372:             self.setrw(rw=rw)
Line 373:         access = rm.LockType.exclusive if rw else rm.LockType.shared
Line 374: 
Line 375:         # active volume
Line 376:         self.activateVolumes(self.volUUID)
This needs to be a list\tuple with one item
Line 377: 
Line 378:         resourcename = self.volUUID + '/' + self.sdUUID
Line 379: 
Line 380:         # acquireResource - open file


Line 394:                       % (sdUUID, volUUID, justme))
Line 395: 
Line 396:         resourcename = volUUID + '/' + sdUUID
Line 397:         rmanager.releaseResource(cls.volWatcherNamespace, resourcename)
Line 398:         cls.deactivateVolumes(volUUID)
list\tuple
Line 399: 
Line 400:         if not justme:
Line 401:             try:
Line 402:                 pvolUUID = _getVolumeTag(sdUUID, volUUID, TAG_PREFIX_PARENT)


....................................................
File vdsm/storage/resourceFactories.py
Line 43:         self._path = lvm.lvPath(lvName, vgName)
Line 44:         try:
Line 45:             self._f = open(self._path)
Line 46:         except Exception as e:
Line 47:             log.error("Cannot open device %s: %s", self._path, e)
Don't catch the exception!
Line 48: 
Line 49:     def close(self):
Line 50:         try:
Line 51:             self._f.close()


Line 49:     def close(self):
Line 50:         try:
Line 51:             self._f.close()
Line 52:         except Exception as e:
Line 53:             log.error("Cannot close device %s: %s", self._path, e)
don't catch the exception!
Line 54: 
Line 55: 
Line 56: class VolumeWatcherFactory(object):
Line 57:     def __init__(self, vgName, lvName):


Line 66:         return True
Line 67: 
Line 68:     def createResource(self, resourceName, lockType):
Line 69:         try:
Line 70:             lvvg = resourceName.split('/')
lv, vg =
Line 71:             return VolumeWatcher(lvvg[0], lvvg[1])
Line 72:         except:
Line 73:             log.error("error creating resource name: %s", resourceName)
Line 74: 


Line 67: 
Line 68:     def createResource(self, resourceName, lockType):
Line 69:         try:
Line 70:             lvvg = resourceName.split('/')
Line 71:             return VolumeWatcher(lvvg[0], lvvg[1])
return VolumeWatcher(lv, vg)
Line 72:         except:
Line 73:             log.error("error creating resource name: %s", resourceName)
Line 74: 
Line 75: 


Line 69:         try:
Line 70:             lvvg = resourceName.split('/')
Line 71:             return VolumeWatcher(lvvg[0], lvvg[1])
Line 72:         except:
Line 73:             log.error("error creating resource name: %s", resourceName)
Don't catch the exception!
Line 74: 
Line 75: 
Line 76: class LvmActivation(object):
Line 77:     """


--
To view, visit http://gerrit.ovirt.org/8084
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic936c8959562a262de5ceba8ca4f68bc53b5cae2
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>


More information about the vdsm-patches mailing list