Change in vdsm[master]: BZ#855924 fix VM config dictionary

peet at redhat.com peet at redhat.com
Mon Oct 15 08:39:53 UTC 2012


Peter V. Saveliev has posted comments on this change.

Change subject: BZ#855924 fix VM config dictionary
......................................................................


Patch Set 8: (2 inline comments)

....................................................
File vdsm/vm.py
Line 132:                 self._dst_version = StrictVersion(str(max(
Line 133:                     self.destServer.getVersionInfo()['info']['supportedRHEVMs']
Line 134:                     )))
Line 135:             except:
Line 136:                 pass
if the target has no such verb, the default version is StrictVersion('3.0')
Line 137:             status = self.destServer.getVmStats(self._vm.id)
Line 138:             if not status['status']['code']:
Line 139:                 self.log.error("Machine already exists on the destination")
Line 140:                 self.status = errCode['exist']


Line 227:             MigrationSourceThread._ongoingMigrations.acquire()
Line 228:             try:
Line 229:                 self.log.debug("migration semaphore acquired")
Line 230:                 # patch VM config for targets < 3.1
Line 231:                 if self._dst_version < StrictVersion('3.1'):
here we can define compatibility levels. E.g.:


if self._dst_version < StrictVersion('3.1'):
   …
elif self._dst_version < StrictVersion('3.2'):
   …
Line 232:                     for i in ('cdrom', 'floppy'):
Line 233:                         try:
Line 234:                             # add cdrom and floppy as paths
Line 235:                             self._vm.conf[i] = [x['path'] for x in \


--
To view, visit http://gerrit.ovirt.org/8378
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I33e957f8daac4266d9e19cc008cf830bd3959521
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>


More information about the vdsm-patches mailing list